Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Migrate Divider demos to hooks #15490

Merged
merged 5 commits into from
Apr 25, 2019
Merged

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Apr 25, 2019

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 25, 2019

No bundle size changes comparing 1155be4...f8b9562

Generated by 🚫 dangerJS against f8b9562

@joshwooding joshwooding added docs Improvements or additions to the documentation typescript labels Apr 25, 2019
@oliviertassinari
Copy link
Member

@merceyz Thanks for this 🔥.

I'm wondering. Have you considered the option to write a codemod for doing the migration? I just an idea. I was wondering about the automation potential and the good it could do to our users 🤔.

@merceyz
Copy link
Member Author

merceyz commented Apr 25, 2019

Thanks for this fire.

I have more which I combined in one branch, just building it up with more changes as to not spam PRs.
Or would you prefer multiple PRs over one giant one?

Have you considered the option to write a codemod for doing the migration?

I haven't, they more or less don't follow the same pattern, depending on when it was written, so would be quite the challenge to automate.

@joshwooding joshwooding merged commit a97c70f into mui:next Apr 25, 2019
@joshwooding
Copy link
Member

Thanks for the great effort! We're well on the way for 100% hook conversion :)

@merceyz
Copy link
Member Author

merceyz commented Apr 25, 2019

Thanks for the great effort!

No problem, thanks for this library making work a lot easier.

We're well on the way for 100% hook conversion :)

#15494 should convert the rest of the TypeScript demos

@merceyz merceyz deleted the docs/dividers branch April 25, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants