-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Migrate Divider demos to hooks #15490
Conversation
merceyz
commented
Apr 25, 2019
- I have followed (at least) the PR section of the contributing guide.
No bundle size changes comparing 1155be4...f8b9562 |
@merceyz Thanks for this 🔥. I'm wondering. Have you considered the option to write a codemod for doing the migration? I just an idea. I was wondering about the automation potential and the good it could do to our users 🤔. |
I have more which I combined in one branch, just building it up with more changes as to not spam PRs.
I haven't, they more or less don't follow the same pattern, depending on when it was written, so would be quite the challenge to automate. |
Co-Authored-By: merceyz <[email protected]>
Co-Authored-By: merceyz <[email protected]>
Co-Authored-By: merceyz <[email protected]>
Thanks for the great effort! We're well on the way for 100% hook conversion :) |
No problem, thanks for this library making work a lot easier.
#15494 should convert the rest of the TypeScript demos |